Vary size of text in social cards #31

New Issue

2020-10-18T03:28:25Z

jaywll commented

2020-10-18 03:28:25 +00:00

(Migrated from gitlab.com)

https://twig.symfony.com/doc/3.x/filters/striptags.html
https://twig.symfony.com/doc/2.x/filters/length.html

https://twig.symfony.com/doc/3.x/filters/striptags.html https://twig.symfony.com/doc/2.x/filters/length.html

jaywll commented

2020-10-22 21:11:39 +00:00

(Migrated from gitlab.com)

                    {% if post.title | striptags | length < 100 %}
                        <h2 class="card-title">{{ post.title | raw | nl2br }}</h2>
                    {% elseif  post.title | striptags | length < 125 %}
                        <p class="card-text main">{{ post.title | raw | nl2br }}</p>
                    {% else %}
                        <p class="card-text">{{ post.title | raw | nl2br }}</p>
                    {% endif %}

``` {% if post.title | striptags | length < 100 %} <h2 class="card-title">{{ post.title | raw | nl2br }}</h2> {% elseif post.title | striptags | length < 125 %} <p class="card-text main">{{ post.title | raw | nl2br }}</p> {% else %} <p class="card-text">{{ post.title | raw | nl2br }}</p> {% endif %} ```

jaywll commented

2020-10-22 21:13:22 +00:00

(Migrated from gitlab.com)

These should probably use different classes throughout, instead of different elements. Too much semantic change.

jaywll commented

2020-10-22 21:20:04 +00:00

(Migrated from gitlab.com)

marked this issue as related to #36

jaywll commented

2020-10-22 21:21:52 +00:00

(Migrated from gitlab.com)

Created issue #36 to address previous comment. Closing this one.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: jason/ja.son-williams.ca#31